Reviewing pull requests

Remember you are not a police officer. You are here to help the contributor get their code integrated and ensure they have a great experience contributing to Invenio.

  1. Check it from the helicopter. If it ain’t green, it ain’t finished. If it ain’t understandable, it ain’t documented.
  1. Beware of inter-module relations. Changing API? Perhaps this pull request may break other modules. Check outside usage. Check the presence of versionadded, versionmodified, deprecated docstring directives.
  1. Beware of inter-service relations. Changing pre-existing tests? Perhaps this pull request does not fit the needs of other Invenio services.
  1. Avoid self merges. Each pull request should be seen by another pair of eyes. Was it authored and reviewed by two different persons? Good. Were the two different persons coming from two different service teams? Better.